nastra commented on code in PR #14480:
URL: https://github.com/apache/iceberg/pull/14480#discussion_r2503038130
##########
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##########
@@ -86,6 +99,9 @@
public class CatalogHandlers {
private static final Schema EMPTY_SCHEMA = new Schema();
private static final String INITIAL_PAGE_TOKEN = "";
+ private static final InMemoryPlanningState IN_MEMORY_PLANNING_STATE =
+ InMemoryPlanningState.getInstance();
Review Comment:
this looks much nicer. I wonder whether we should actually push all of the
server-side scan planning state + behavior into a wrapper class. That way also
`CatalogHandlers` becomes cleaner and you have everything related to
server-side scan planning in a single class. This isn't a blocker but I was
just curious how that would look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
