parthchandra commented on code in PR #13786:
URL: https://github.com/apache/iceberg/pull/13786#discussion_r2504627458
##########
parquet/src/main/java/org/apache/iceberg/parquet/ReadConf.java:
##########
@@ -60,7 +60,7 @@ class ReadConf<T> {
private final List<Map<ColumnPath, ColumnChunkMetaData>>
columnChunkMetaDataForRowGroups;
@SuppressWarnings("unchecked")
- ReadConf(
+ public ReadConf(
Review Comment:
Yes we do. The Comet reader is now in a different module and needs to access
the read conf for read information. I could make it protected and then derive a
class explicitly meant for custom readers, but that seems overkill.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
