pvary commented on code in PR #14312:
URL: https://github.com/apache/iceberg/pull/14312#discussion_r2455069904
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicIcebergSink.java:
##########
@@ -423,6 +426,26 @@ void testPartitionSpecEvolution() throws Exception {
new DynamicIcebergDataImpl(SimpleDataUtil.SCHEMA, "t1", "main",
spec2));
runTest(rows);
+
+ // Validate the table has expected partition specs
+ Table table =
CATALOG_EXTENSION.catalog().loadTable(TableIdentifier.of(DATABASE, "t1"));
+
+ Map<Integer, PartitionSpec> tableSpecs = table.specs();
+ List<PartitionSpec> expectedSpecs = List.of(spec1, spec2,
PartitionSpec.unpartitioned());
+
+ assertThat(tableSpecs).hasSize(expectedSpecs.size());
+ expectedSpecs.forEach(
+ expectedSpec ->
+ assertThat(
+ tableSpecs.values().stream()
+ // TODO: Fix PartitionSpecEvolution#evolve to re-use
PartitionField names of
Review Comment:
How complicated this change would be in the `evolve`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
