pvary commented on code in PR #14312:
URL: https://github.com/apache/iceberg/pull/14312#discussion_r2455035563
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicCommitter.java:
##########
@@ -155,6 +152,7 @@ public void
commit(Collection<CommitRequest<DynamicCommittable>> commitRequests)
}
}
+ /** TODO: Reuse {@link
org.apache.iceberg.flink.sink.SinkUtil#getMaxCommittedCheckpointId} * */
Review Comment:
Why is this for the future?
This code is a duplication which we should remove here, or maybe even in a
different commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
