gaborkaszab commented on code in PR #14387:
URL: https://github.com/apache/iceberg/pull/14387#discussion_r2450559180
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteTablePathsAction.java:
##########
@@ -386,29 +388,46 @@ public void testDeleteDataFile() throws Exception {
.hasSize(1);
}
- @Test
- public void testPositionDeletes() throws Exception {
+ @ParameterizedTest
+ @ValueSource(strings = {"avro", "parquet", "orc"})
Review Comment:
The reason is that the code I changed had no test coverage at all: we only
tested rewriting Parquet pos deletes, but the change was on the Avro path. I
can split that into a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
