gaborkaszab commented on code in PR #14387:
URL: https://github.com/apache/iceberg/pull/14387#discussion_r2452531286
##########
spark/v4.0/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteTablePathsAction.java:
##########
@@ -386,29 +388,46 @@ public void testDeleteDataFile() throws Exception {
.hasSize(1);
}
- @Test
- public void testPositionDeletes() throws Exception {
+ @ParameterizedTest
+ @ValueSource(strings = {"avro", "parquet", "orc"})
Review Comment:
@nastra I gave this a second thought: file format doesn't matter much for
most of the tests in this suite, because they rewrite metadata files (only Avro
atm) and some test also rewrite positional delete files. I observed that this
suite runs pretty long, over 5 mins without parameterization, but once I added
the 3 file formats as params, the runtime grew to almost 15 mins.
So I'd be careful how much test suite level dimension we introduce here as
it can significantly increase runtime and probably doesn't add much to the test
coverage. I'd prefer to add the file format param only to the tests that are
relevant for pos deletes. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
