zhjwpku commented on code in PR #267:
URL: https://github.com/apache/iceberg-cpp/pull/267#discussion_r2448743998
##########
src/iceberg/util/temporal_util.h:
##########
@@ -38,6 +53,24 @@ class ICEBERG_EXPORT TemporalUtils {
/// \brief Extract a timestamp hour, as hours from 1970-01-01 00:00:00
static Result<Literal> ExtractHour(const Literal& literal);
+
+ /// \brief Construct a Calendar date without timezone or time
+ static int32_t CreateDate(const TemporalParts& parts);
Review Comment:
I just moved these constructors into the test directory, not user-facing API
any more, so I think returning the value directly should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
