wgtmac commented on code in PR #267:
URL: https://github.com/apache/iceberg-cpp/pull/267#discussion_r2446574219
##########
src/iceberg/util/temporal_util.h:
##########
@@ -19,12 +19,27 @@
#pragma once
+#include <cstdint>
+
#include "iceberg/iceberg_export.h"
#include "iceberg/result.h"
#include "iceberg/type_fwd.h"
namespace iceberg {
+struct ICEBERG_EXPORT TemporalParts {
Review Comment:
I was thinking that only adding these structures to the test directory to
make it easy for us to create `Date`, `Time` and `Timestamp` values in the test
cases. Temporal values are notorious to deal with, especially when it comes to
timezone and daylight saving rules. We don't want to expose such APIs
externally and maintain it hereafter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
