amogh-jahagirdar commented on code in PR #14287:
URL: https://github.com/apache/iceberg/pull/14287#discussion_r2445987827
##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -735,7 +741,8 @@ public void dataFilesCleanupWithParallelTasks() throws
IOException {
assertThat(deletedFiles).contains(FILE_B.location());
assertThat(planThreadsIndex.get())
.as("Thread should be created in provided pool")
- .isGreaterThan(0);
+ // incremental with retain will not use plan executor
+ .isGreaterThanOrEqualTo(0);
Review Comment:
I'm guessing this code comment just doesn't apply, and the test passes since
it's testing for >= 0 and we're really > 0. So I think this assertion just
needs to go back to it's previous state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
