dramaticlly commented on code in PR #14287:
URL: https://github.com/apache/iceberg/pull/14287#discussion_r2441276447
##########
core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java:
##########
@@ -59,16 +60,24 @@
@ExtendWith(ParameterizedTestExtension.class)
public class TestRemoveSnapshots extends TestBase {
+
@Parameter(index = 1)
private boolean incrementalCleanup;
- @Parameters(name = "formatVersion = {0}, incrementalCleanup = {1}")
+ @Parameter(index = 2)
+ private boolean retainDataFile;
+
+ @Parameters(name = "formatVersion = {0}, incrementalCleanup = {1},
retainDataFile = {2}")
protected static List<Object> parameters() {
return Arrays.asList(
- new Object[] {1, true},
- new Object[] {2, true},
- new Object[] {1, false},
- new Object[] {2, false});
+ new Object[] {1, true, false},
Review Comment:
Removed the extra parameter and updated the test with new CleanupMode, ready
for another look @amogh-jahagirdar !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
