kevinjqliu commented on code in PR #1758:
URL: https://github.com/apache/iceberg-rust/pull/1758#discussion_r2445508575
##########
crates/iceberg/src/delete_file_index.rs:
##########
@@ -201,10 +203,282 @@ impl PopulatedDeleteFileIndex {
seq_num
.map(|seq_num| delete.manifest_entry.sequence_number()
>= Some(seq_num))
.unwrap_or_else(|| true)
+ && data_file.partition_spec_id ==
delete.partition_spec_id
Review Comment:
lets see if we can refactor this in a follow up PR and keep the changes here
straightforward :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
