amogh-jahagirdar commented on code in PR #1758:
URL: https://github.com/apache/iceberg-rust/pull/1758#discussion_r2443427976
##########
crates/iceberg/src/delete_file_index.rs:
##########
@@ -169,10 +169,10 @@ impl PopulatedDeleteFileIndex {
self.global_deletes
.iter()
- // filter that returns true if the provided delete file's sequence
number is **greater than or equal to** `seq_num`
+ // filter that returns true if the provided delete file's sequence
number is **greater than** `seq_num`
Review Comment:
Yeah, thanks for finding that github thread, looks like the confusion was
what global_deletes meant, but really it's global equality deletes. Regardless
any equality delete must be applied for files strictly older. I also fixed some
of the partition scoped delete matching logic because it's technically possible
to have tuples match but the spec IDs don't match; currently we only go off the
tuple which isn't quite correct for matching as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
