shangxinli commented on code in PR #14041:
URL: https://github.com/apache/iceberg/pull/14041#discussion_r2373855548
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetFilters.java:
##########
@@ -233,6 +266,29 @@ private static <C extends Comparable<C>> C
getParquetPrimitive(Literal<?> lit) {
"Type not supported yet: " + value.getClass().getName());
}
+ @SuppressWarnings("unchecked")
+ private static <C extends Comparable<C>> Set<C>
getParquetPrimitiveSet(Set<?> litSet) {
+ if (litSet == null) {
+ return Collections.emptySet();
+ }
+
+ // TODO: this needs to convert to handle BigDecimal and UUID
+ Set<C> convertedSet = Sets.newHashSet();
Review Comment:
if we add everything from litSet to convertedSet, should we initialize it
with the size parameter as Sets.newHashSet(litSet); It would be more efficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
