tomtongue commented on code in PR #14212:
URL: https://github.com/apache/iceberg/pull/14212#discussion_r2412545300
##########
spark/v4.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##########
@@ -2113,6 +2113,22 @@ public void createViewWithCustomMetadataLocation() {
""));
}
+ @TestTemplate
+ public void createViewWithCustomMetadataLocationWithLocation() {
+ String viewName = viewName("v");
+ String customMetadataLocation =
+ Paths.get(temp.toUri().toString(),
"custom-metadata-location").toString();
+ sql(
+ "CREATE VIEW %s TBLPROPERTIES ('location'='%s') AS SELECT * FROM %s",
+ viewName, customMetadataLocation, tableName);
+
+ assertThat(sql("SHOW TBLPROPERTIES %s", viewName))
+ .contains(row("location", customMetadataLocation));
+
+ String location = viewCatalog().loadView(TableIdentifier.of(NAMESPACE,
viewName)).location();
+ assertThat(location).isEqualTo(customMetadataLocation);
+ }
+
Review Comment:
@flyrain @huaxingao Thanks, I believe it's good to support `ALTER TABLE SET
TBLPROPERTIES` (I don't think adding a new clause like `LOCATION` into Spark is
a good option because only Iceberg needs the location for its view for now) Let
me try to make `location` configurable as a non-reserved property, and consider
the way to handle `location`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
