tomtongue commented on code in PR #14212:
URL: https://github.com/apache/iceberg/pull/14212#discussion_r2401880785
##########
spark/v4.0/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java:
##########
@@ -2113,6 +2113,22 @@ public void createViewWithCustomMetadataLocation() {
""));
}
+ @TestTemplate
+ public void createViewWithCustomMetadataLocationWithLocation() {
+ String viewName = viewName("v");
+ String customMetadataLocation =
+ Paths.get(temp.toUri().toString(),
"custom-metadata-location").toString();
+ sql(
+ "CREATE VIEW %s TBLPROPERTIES ('location'='%s') AS SELECT * FROM %s",
+ viewName, customMetadataLocation, tableName);
+
+ assertThat(sql("SHOW TBLPROPERTIES %s", viewName))
+ .contains(row("location", customMetadataLocation));
+
+ String location = viewCatalog().loadView(TableIdentifier.of(NAMESPACE,
viewName)).location();
+ assertThat(location).isEqualTo(customMetadataLocation);
+ }
+
Review Comment:
Thanks for adding that info, yes when you run `ALTER TABLE SET
TBLPROPERTIES` or `UNSET TBLPROPERTIES`, they failed with the parce exception
with the error showing `location is a reseved property` like Spark. So as
you're mentioning, this would be another limitation that users cannot change
the view metadata location after they create a view. I believe there are not so
many cases like changing view metadata location after creating the view, but is
there any concern on this limitation? @ebyhr
And if you have any concern on the limitation, could you share it? @flyrain
@huaxingao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
