wgtmac commented on code in PR #206:
URL: https://github.com/apache/iceberg-cpp/pull/206#discussion_r2375081597
##########
test/literal_test.cc:
##########
@@ -263,22 +457,18 @@ TEST(LiteralTest, CrossTypeComparison) {
EXPECT_EQ(int_literal <=> string_literal, std::partial_ordering::unordered);
}
-// Special value tests
-TEST(LiteralTest, SpecialValues) {
+// Same type cast tests
+TEST(LiteralTest, SameTypeCast) {
Review Comment:
As discussed offline, please refactor this file to use parameterized test to
use common code for testing different data types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
