wgtmac commented on code in PR #206:
URL: https://github.com/apache/iceberg-cpp/pull/206#discussion_r2418878688
##########
src/iceberg/test/literal_test.cc:
##########
@@ -30,257 +30,147 @@
namespace iceberg {
-// Boolean type tests
-TEST(LiteralTest, BooleanBasics) {
- auto true_literal = Literal::Boolean(true);
- auto false_literal = Literal::Boolean(false);
-
- EXPECT_EQ(true_literal.type()->type_id(), TypeId::kBoolean);
- EXPECT_EQ(false_literal.type()->type_id(), TypeId::kBoolean);
-
- EXPECT_EQ(true_literal.ToString(), "true");
- EXPECT_EQ(false_literal.ToString(), "false");
+namespace {
+
+// Helper function to assert that a CastTo operation succeeds and checks
+// the resulting type and value.
+template <typename T>
+void AssertCastSucceeds(const Result<Literal>& result, TypeId expected_type_id,
Review Comment:
Let's remove it since not used anywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
