stevenzwu commented on code in PR #14271:
URL: https://github.com/apache/iceberg/pull/14271#discussion_r2411249896
##########
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##########
@@ -71,6 +72,23 @@ protected BaseTaskWriter(
this.spec = spec;
this.format = format;
this.appenderFactory = appenderFactory;
+ this.writerFactory = null;
+ this.fileFactory = fileFactory;
+ this.io = io;
+ this.targetFileSize = targetFileSize;
+ }
+
+ protected BaseTaskWriter(
Review Comment:
I guess this is an approach with minimal effort to move Flink to
FileWriterFactory.
Otherwise, the intention is probably for Flink and Kafka to move away from
`BaseTaskWriter` as well. E.g., Spark is using `FanoutDataWriter` and
`ClusteredDataWriter`.
Should we move Flink to use `PartitioningWriter`? might be a bigger change
though.
##########
core/src/main/java/org/apache/iceberg/io/PartitionedWriter.java:
##########
@@ -46,6 +46,16 @@ protected PartitionedWriter(
super(spec, format, appenderFactory, fileFactory, io, targetFileSize);
}
+ protected PartitionedWriter(
Review Comment:
looks like PartitionedWriter is not used in Iceberg repo anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
