stevenzwu commented on code in PR #14271:
URL: https://github.com/apache/iceberg/pull/14271#discussion_r2418072889
##########
core/src/main/java/org/apache/iceberg/io/BaseTaskWriter.java:
##########
@@ -71,6 +72,23 @@ protected BaseTaskWriter(
this.spec = spec;
this.format = format;
this.appenderFactory = appenderFactory;
+ this.writerFactory = null;
+ this.fileFactory = fileFactory;
+ this.io = io;
+ this.targetFileSize = targetFileSize;
+ }
+
+ protected BaseTaskWriter(
Review Comment:
I am fine with this approach. It doesn't require a big effort to migrate
Flink to FileWriterFactory as an intermediate step, although if-else isn't
perfect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
