jaimeferj commented on code in PR #2561:
URL: https://github.com/apache/iceberg-python/pull/2561#discussion_r2402125408
##########
pyiceberg/expressions/__init__.py:
##########
@@ -732,6 +734,39 @@ def __init__(self, term: Union[str, UnboundTerm[Any]],
literal: Union[L, Literal
super().__init__(term)
self.literal = _to_literal(literal) # pylint: disable=W0621
+ # ---- JSON (Pydantic) serialization helpers ----
+
+ class _LiteralPredicateModel(IcebergBaseModel):
Review Comment:
It was the first approach that I went for to not subclass the generic
LiteralPredicate with IcebergBaseModel. I will subclass every specialization of
LiteralPredicate from IcebergBaseModel and commit the changes and see if it
makes more sense for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
