Fokko commented on code in PR #1682:
URL: https://github.com/apache/iceberg-rust/pull/1682#discussion_r2372156146
##########
crates/iceberg/src/spec/manifest/writer.rs:
##########
@@ -96,7 +108,51 @@ impl ManifestWriterBuilder {
.format_version(FormatVersion::V2)
.content(ManifestContentType::Deletes)
.build();
- ManifestWriter::new(self.output, self.snapshot_id, self.key_metadata,
metadata)
+ ManifestWriter::new(
+ self.output,
+ self.snapshot_id,
+ self.key_metadata,
+ metadata,
+ None,
+ )
+ }
+
+ /// Build a [`ManifestWriter`] for format version 2, data content.
+ pub fn build_v3_data(self) -> ManifestWriter {
+ let metadata = ManifestMetadata::builder()
+ .schema_id(self.schema.schema_id())
+ .schema(self.schema)
+ .partition_spec(self.partition_spec)
+ .format_version(FormatVersion::V3)
+ .content(ManifestContentType::Data)
+ .build();
+ ManifestWriter::new(
+ self.output,
+ self.snapshot_id,
+ self.key_metadata,
+ metadata,
+ // First row id is assigned by the [`ManifestListWriter`] when the
manifest
+ // is added to the list.
+ None,
+ )
+ }
+
+ /// Build a [`ManifestWriter`] for format version 2, deletes content.
Review Comment:
```suggestion
/// Build a [`ManifestWriter`] for format version 3, deletes content.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
