CTTY commented on code in PR #1682:
URL: https://github.com/apache/iceberg-rust/pull/1682#discussion_r2389477295
##########
crates/iceberg/src/spec/manifest/entry.rs:
##########
@@ -533,6 +569,8 @@ fn data_file_fields_v2(partition_type: &StructType) ->
Vec<NestedFieldRef> {
SORT_ORDER_ID.clone(),
FIRST_ROW_ID.clone(),
REFERENCE_DATA_FILE.clone(),
+ // Why are the following two fields here in the existing v2 schema?
+ // In the spec, they are not even listed as optional for v2.
Review Comment:
I have the same doubt and this question also applies to the `FIRST_ROW_ID`
above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
