laurentgo commented on code in PR #14196:
URL: https://github.com/apache/iceberg/pull/14196#discussion_r2425608270
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -1903,6 +2003,39 @@ components:
schema:
type: string
+ idempotency-key:
+ name: Idempotency-Key
+ in: header
+ required: false
+ schema:
+ type: string
+ format: uuid
+ minLength: 36
+ maxLength: 36
+ example: "550e8400-e29b-41d4-a716-446655440000"
+ description: |
+ Optional client-provided idempotency key for safe request retries.
+
+ When present, the server ensures no additional effects for requests
that carry the same
+ Idempotency-Key within the same operation/resource scope. If a prior
request with this key
+ has been finalized, the server returns an equivalent final response
without re-running the
+ operation. The response body may reflect a newer state of the table
than existed at the
+ time of the commit.
+
+ Finalization rules:
+ - Finalize & replay: 200, 201, 204, and deterministic terminal 4xx
+ - Do not finalize (not stored/replayed): 5xx, 409
(RequestInProgressException)
+
+ Key Requirements:
+ - Key format: UUID (V7 preferred) in string format as defined in RFC
9562 Section 4.
+ See https://datatracker.ietf.org/doc/html/rfc9562#sampleStringUUID
for the textual
+ representation specification.
+ - Scoped to operation type and resource path; the idempotency key must
be unique per
+ (operation type, resource path) pair (e.g., updateTable on db.t1)
+ - Catalogs MUST NOT expire keys before the end of the advertised token
lifetime.
Review Comment:
There's no way to guarantee that the key won't be removed a bit before
because of clock skew but maybe because the keys are not persisted in a durable
storage but maybe in some cache (for both performance and cost reasons).
For me, use of `MUST NOT` is too strong, and should be a `SHOULD NOT` at
best.
Isn't it a API issue then if re-applying the same operation is being retried
and is causing corruption?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
