WillAyd commented on code in PR #233:
URL: https://github.com/apache/iceberg-cpp/pull/233#discussion_r2388160446
##########
src/iceberg/json_internal.h:
##########
@@ -38,7 +38,7 @@ namespace iceberg {
///
/// \param sort_field The `SortField` object to be serialized.
/// \return A JSON object representing the `SortField` in the form of
key-value pairs.
-nlohmann::json ToJson(const SortField& sort_field);
+ICEBERG_EXPORT nlohmann::json ToJson(const SortField& sort_field);
Review Comment:
I'll didn't dive too deeply into this but it was to fix an error with the
linker. Meson makes it much easier to use hidden symbol visibility by default
than CMake (see the gnu_symbol_visibility argument to the library call).
My guess is this issue would also exist in the CMake build if we didn't use
default symbol visibility, but I'll look deeper into it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
