pvary commented on PR #14182: URL: https://github.com/apache/iceberg/pull/14182#issuecomment-3337795737
> More generally, I think `DynamicCommitter` should not be responsible for aggregating WriteResults from a _single checkpoint_. There is a dedicated class for this - `DynamicWriteResultAggregator`, which decides how commit requests (DynamicCommittables) are created. @aiborodin: This seems like a reasonable optimization for me. OTOH the correctness issue could be solved with a lightweight change (don't commit every WriteResult one-by-one, but first aggregate on the Committer side). This could go in to 1.10.1, and then the optimization you have suggested could go in to 1.11.0. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
