HeartLinked commented on code in PR #185:
URL: https://github.com/apache/iceberg-cpp/pull/185#discussion_r2380702420
##########
src/iceberg/expression/literal.h:
##########
@@ -143,11 +144,76 @@ class ICEBERG_EXPORT Literal {
private:
Literal(Value value, std::shared_ptr<PrimitiveType> type);
+ friend class Conversions;
friend class LiteralCaster;
- private:
Review Comment:
There is another one above. I guess this is repeated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
