zhjwpku commented on code in PR #185:
URL: https://github.com/apache/iceberg-cpp/pull/185#discussion_r2368102928
##########
src/iceberg/expression/literal.cc:
##########
@@ -151,11 +155,11 @@ Literal Literal::Binary(std::vector<uint8_t> value) {
Result<Literal> Literal::Deserialize(std::span<const uint8_t> data,
std::shared_ptr<PrimitiveType> type) {
- return NotImplemented("Deserialization of Literal is not implemented yet");
+ return Conversions::FromBytes(type, data);
Review Comment:
Why wasn't the suggested code adopted? I share the same concern ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
