slfan1989 commented on code in PR #14179:
URL: https://github.com/apache/iceberg/pull/14179#discussion_r2377809571
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/BaseProcedure.java:
##########
@@ -57,6 +58,14 @@ abstract class BaseProcedure implements Procedure {
DataTypes.createMapType(DataTypes.StringType, DataTypes.StringType);
protected static final DataType STRING_ARRAY =
DataTypes.createArrayType(DataTypes.StringType);
+ protected static ProcedureParameter requiredInParameter(String name,
DataType dataType) {
+ return ProcedureParameter.required(name, dataType);
+ }
+
+ protected static ProcedureParameter optionalInParameter(String name,
DataType dataType) {
+ return ProcedureParameter.optional(name, dataType);
+ }
Review Comment:
In Spark 3.5, we use
`org.apache.spark.sql.connector.iceberg.catalog.ProcedureParameter` for
parameter parsing, whereas in the Spark 4 branch,
`org.apache.spark.sql.connector.catalog.procedures.ProcedureParameter` is used
to achieve the same functionality. Personally, I believe the difference in
functionality between the two is not significant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
