slfan1989 commented on code in PR #14179:
URL: https://github.com/apache/iceberg/pull/14179#discussion_r2377497234
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/BaseProcedure.java:
##########
@@ -57,6 +58,14 @@ abstract class BaseProcedure implements Procedure {
DataTypes.createMapType(DataTypes.StringType, DataTypes.StringType);
protected static final DataType STRING_ARRAY =
DataTypes.createArrayType(DataTypes.StringType);
+ protected static ProcedureParameter requiredInParameter(String name,
DataType dataType) {
+ return ProcedureParameter.required(name, dataType);
+ }
+
+ protected static ProcedureParameter optionalInParameter(String name,
DataType dataType) {
+ return ProcedureParameter.optional(name, dataType);
+ }
Review Comment:
Thank you very much for reviewing the code! This is not a clean backport,
since there is a PR (#13106) in the Spark 4.0 branch that cannot be directly
backported to Spark 3.4/3.5. Because Spark 3.5 lacks some features compared to
Spark 4.0, I made certain adjustments based on the current Spark 3.5 code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
