RussellSpitzer commented on code in PR #14040:
URL: https://github.com/apache/iceberg/pull/14040#discussion_r2334907095
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java:
##########
@@ -75,6 +78,16 @@ protected ParquetValueReader<T> createReader(
}
}
+ /**
+ * This method can be overridden to provide a custom implementation which
also uses the fieldId of
+ * the Schema when creating the struct reader
+ */
+ protected ParquetValueReader<T> createStructReader(
Review Comment:
This is key for allowing InternalParquet to use the field Id to lookup what
structlike class should be used for a particular field. This also is the reason
for the RevAPI breaks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
