RussellSpitzer commented on code in PR #14040:
URL: https://github.com/apache/iceberg/pull/14040#discussion_r2334926982
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/InternalReader.java:
##########
@@ -30,27 +31,45 @@
public class InternalReader<T extends StructLike> extends
BaseParquetReaders<T> {
Review Comment:
I've changed this into a stateful reader so that Parquet.java can set custom
classes for the reader to use. I'm definitely open to other ways around this.
The previous approach was for Parquet to statically used the create method to
generate a reader for "readerFunc", this had the problem that each call to set
custom types would happen after the reader func was set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
