pvary commented on issue #14096: URL: https://github.com/apache/iceberg/issues/14096#issuecomment-3311947928
> Is there a benefit to not passing the expected metadata location when using hive locks? Is it just performance? The original goal was to have a way to revert back to the original functionality if we made any mistake with the implementation. For example we found an issue with the MySQL implementation of the `expected_parameter_key` (see: `HIVE-28121`), and we had to ask the users to turn off the feature until we fixed the issue in the HMS code. So generally it is good to isolate the different implementations. Your correctness issue could be a compelling reason to reconsider this. The issue would not be solved by your environment, as Hive 3.1.2 doesn't have this feature. Another question is: - What happens after 6. if the HMS returns an error? Will we commit fail, and delete the metadata/data files added by AlterTable0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
