huaxingao commented on code in PR #14059:
URL: https://github.com/apache/iceberg/pull/14059#discussion_r2353334789
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -122,7 +122,7 @@ public S3FileIO() {}
* @param s3 s3 supplier
*/
public S3FileIO(SerializableSupplier<S3Client> s3) {
- this(s3, null, new S3FileIOProperties());
+ this.s3 = s3;
Review Comment:
same as the 2 arg constructor, to keep the same behavior as before, we still
need
```
this.createStack = Thread.currentThread().getStackTrace();
this.properties = SerializableMap.copyOf(new
S3FileIOProperties().properties());
```
After fixing the 2 arg constructor, call the 2 arg constructor
```
this(s3, /* s3Async = */ null);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
