dogukancagatay commented on code in PR #14059:
URL: https://github.com/apache/iceberg/pull/14059#discussion_r2347237088
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java:
##########
@@ -186,7 +185,12 @@ private static OAuthTokenResponse refreshToken(
}
return fetchToken(
- client, Map.of(), config.credential(), config.scope(),
config.oauth2ServerUri());
+ client,
+ Map.of(),
+ config.credential(),
+ config.scope(),
+ config.oauth2ServerUri(),
+ optionalOAuthParams);
Review Comment:
I see this as a functional improvement rather than a fix. My assumption was
that replacing the deprecated method was intended to allow passing these
optional parameters, which were previously ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
