yeswanth-s1th commented on code in PR #13664:
URL: https://github.com/apache/iceberg/pull/13664#discussion_r2307659142
##########
site/dev/common.sh:
##########
@@ -175,16 +175,17 @@ update_version () {
assert_not_empty "${ICEBERG_VERSION}"
# Update version information within the mkdocs.yml file using sed commands
- if [ "$(uname)" == "Darwin" ]
+ if [ "$(uname)" == "Darwin" ];
Review Comment:
- Removed the stray `;` after the Darwin uname check.
- No functional change; restores the style used elsewhere in the script.
##########
site/dev/common.sh:
##########
@@ -177,14 +177,15 @@ update_version () {
# Update version information within the mkdocs.yml file using sed commands
if [ "$(uname)" == "Darwin" ]
then
- /usr/bin/sed -i '' -E
"s/(^site\_name:[[:space:]]+docs\/).*$/\1${ICEBERG_VERSION}/"
${ICEBERG_VERSION}/mkdocs.yml
- /usr/bin/sed -i '' -E
"s/(^[[:space:]]*-[[:space:]]+Javadoc:.*\/javadoc\/).*$/\1${ICEBERG_VERSION}/"
${ICEBERG_VERSION}/mkdocs.yml
- elif [ "$(expr substr $(uname -s) 1 5)" == "Linux" ]
+ /usr/bin/sed -i '' -E
"s/(^site_name:[[:space:]]+docs\/).*$/\1${ICEBERG_VERSION}/"
"${ICEBERG_VERSION}/mkdocs.yml"
Review Comment:
I rechecked the block and made a small adjustment: on Linux I kept the
original token-level pattern ([^[:space:]]+) so only the version number gets
replaced and nothing else on the line is touched. On macOS and for the Javadoc
lines I left them as they are in main (.*$) so behavior there doesn’t change. I
also added quotes around $(uname -s) for safety. This keeps the change minimal
but addresses the concern you raised.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
