yeswanth-s1th commented on code in PR #13664:
URL: https://github.com/apache/iceberg/pull/13664#discussion_r2350523327
##########
site/dev/common.sh:
##########
@@ -177,14 +177,15 @@ update_version () {
# Update version information within the mkdocs.yml file using sed commands
if [ "$(uname)" == "Darwin" ]
then
- /usr/bin/sed -i '' -E
"s/(^site\_name:[[:space:]]+docs\/).*$/\1${ICEBERG_VERSION}/"
${ICEBERG_VERSION}/mkdocs.yml
- /usr/bin/sed -i '' -E
"s/(^[[:space:]]*-[[:space:]]+Javadoc:.*\/javadoc\/).*$/\1${ICEBERG_VERSION}/"
${ICEBERG_VERSION}/mkdocs.yml
- elif [ "$(expr substr $(uname -s) 1 5)" == "Linux" ]
+ /usr/bin/sed -i '' -E
"s/(^site_name:[[:space:]]+docs\/).*$/\1${ICEBERG_VERSION}/"
"${ICEBERG_VERSION}/mkdocs.yml"
Review Comment:
Thanks for following up. Yes, I’ve rechecked this.
On Linux, I kept the original token-level pattern ([^[:space:]]+) so it only
replaces the version number after docs/ without affecting anything else on the
line. On macOS and for the Javadoc lines, I left them as they are in main (.*$)
so their behavior doesn’t change.
I also added quotes around $(uname -s) for safety. This keeps the behavior
consistent with main while addressing the earlier concern, and keeps the change
minimal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
