jshmchenxi commented on PR #14041: URL: https://github.com/apache/iceberg/pull/14041#issuecomment-3290703730
> This looks generally good to me but I'm wondering if we have adequate test coverage for the feature? Do we have tests that are using the IN predicate already that cover this? It seems the existing tests using IN predicate are from row group filters: - data/src/test/java/org/apache/iceberg/data/TestMetricsRowGroupFilter.java - parquet/src/test/java/org/apache/iceberg/parquet/TestBloomRowGroupFilter.java - parquet/src/test/java/org/apache/iceberg/parquet/TestDictionaryRowGroupFilter.java Iceberg currently lacks support for page skipping, thus the pushed Parquet filter actually does not help filtering records inside a row group IIUC. A working test case for predicate pushdown can be added along with page skipping feature, similar to https://github.com/apache/iceberg/pull/10228/files#diff-2fc3ebd599749d66bd75f9eb14e030aa97f2fc09e775d7ba372e73f46db25da8. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
