RussellSpitzer commented on code in PR #14041:
URL: https://github.com/apache/iceberg/pull/14041#discussion_r2345426163
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetFilters.java:
##########
@@ -175,7 +204,7 @@ public <T> FilterPredicate predicate(UnboundPredicate<T>
pred) {
@SuppressWarnings("checkstyle:MethodTypeParameterName")
private static <C extends Comparable<C>, COL extends Operators.Column<C> &
Operators.SupportsLtGt>
- FilterPredicate pred(Operation op, COL col, C value) {
+ FilterPredicate pred(Operation op, COL col, C value, Set<C> valueSet) {
Review Comment:
Is this how this is handled in Spark? I may be in the minority here but I
would prefer two different pred functions, one which uses Set<C> and the other
using C. Then only calling the one which is appropriate based on usage rather
than having both arguments and using different args based on the predicate type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
