RussellSpitzer commented on code in PR #7770:
URL: https://github.com/apache/iceberg/pull/7770#discussion_r2342291427
##########
core/src/main/java/org/apache/iceberg/ManifestWriter.java:
##########
@@ -192,6 +194,18 @@ public long length() {
public ManifestFile toManifestFile() {
Preconditions.checkState(closed, "Cannot build ManifestFile, writer is not
closed");
+
+ // if key metadata can store the length, add it
Review Comment:
The comment here is a little opaque. This only applies to
NativeEncryptionKeyMetadata so maybe we should just drop the comment and maybe
instead comment on why the length needs to be added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
