ggershinsky commented on code in PR #7770:
URL: https://github.com/apache/iceberg/pull/7770#discussion_r2335873034
##########
core/src/main/java/org/apache/iceberg/ManifestLists.java:
##########
@@ -47,26 +50,52 @@ static List<ManifestFile> read(InputFile manifestList) {
}
}
+ // or should we modify all related tests (to pass
PlaintextEncryptionManager)?
Review Comment:
> I prefer passing `PlaintextEncryptionManager`, sine that's the API we want
to adopt going forward.
To clarify: the preference is to remove this extra API (in
ManifestLists.java), and pass `PlaintextEncryptionManager` to the 7 classes in
`iceberg-core.test` and `iceberg-core.jmh` ?
(I'm fine either way)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
