pvary commented on code in PR #14040:
URL: https://github.com/apache/iceberg/pull/14040#discussion_r2336700233
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/InternalReader.java:
##########
@@ -72,4 +91,12 @@ protected ParquetValueReader<?> timeReader(ColumnDescriptor
desc) {
protected ParquetValueReader<?> timestampReader(ColumnDescriptor desc,
boolean isAdjustedToUTC) {
return ParquetValueReaders.timestamps(desc);
}
+
+ public void setCustomType(int fieldId, Class<? extends StructLike> type) {
+ this.typesById.put(fieldId, type);
Review Comment:
nit: Are we using `this` in these cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]