stevenzwu commented on code in PR #14040:
URL: https://github.com/apache/iceberg/pull/14040#discussion_r2335138340
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java:
##########
@@ -53,6 +53,9 @@
import org.apache.parquet.schema.Type;
abstract class BaseParquetReaders<T> {
+ // Root ID is used for the top-level struct in the Parquet Schema
+ protected static final int ROOT_ID = 1;
Review Comment:
1 is a valid field id. should use use invalid value like `0` or `-1`?
##########
core/src/test/java/org/apache/iceberg/TestInternalData.java:
##########
@@ -0,0 +1,245 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.IOException;
+import java.nio.file.Path;
+import java.util.Arrays;
+import java.util.List;
+import org.apache.iceberg.data.GenericRecord;
+import org.apache.iceberg.data.Record;
+import org.apache.iceberg.io.CloseableIterable;
+import org.apache.iceberg.io.FileAppender;
+import org.apache.iceberg.io.FileIO;
+import org.apache.iceberg.io.InputFile;
+import org.apache.iceberg.io.OutputFile;
+import org.apache.iceberg.relocated.com.google.common.collect.Lists;
+import org.apache.iceberg.types.Types;
+import org.junit.jupiter.api.TestTemplate;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.io.TempDir;
+
+@ExtendWith(ParameterizedTestExtension.class)
+public class TestInternalData {
+
+ @Parameter(index = 0)
+ private String format;
+
+ @Parameters(name = "format={0}")
+ public static Object[][] parameters() {
+ return new Object[][] {{"avro"}, {"parquet"}};
+ }
+
+ private static final Schema NESTED_SCHEMA =
+ new Schema(
+ Types.NestedField.required(1, "outer_id", Types.LongType.get()),
+ Types.NestedField.optional(
+ 2,
+ "nested_struct",
+ Types.StructType.of(
+ Types.NestedField.optional(3, "inner_id",
Types.LongType.get()),
+ Types.NestedField.optional(4, "inner_name",
Types.StringType.get()))));
+
+ @TempDir private Path tempDir;
+
+ private final FileIO fileIO = new TestTables.LocalFileIO();
+
+ @TestTemplate
+ public void testCustomRootType() throws IOException {
+ FileFormat fileFormat = FileFormat.fromString(format);
+ OutputFile outputFile = fileIO.newOutputFile(tempDir.resolve("test." +
format).toString());
+
+ List<Record> testData = createSimpleTestRecords();
+
+ try (FileAppender<Record> appender =
+ InternalData.write(fileFormat,
outputFile).schema(simpleSchema()).build()) {
+ appender.addAll(testData);
+ }
+
+ InputFile inputFile = fileIO.newInputFile(outputFile.location());
+ List<PartitionData> readRecords = Lists.newArrayList();
+
+ try (CloseableIterable<PartitionData> reader =
+ InternalData.read(fileFormat, inputFile)
+ .project(simpleSchema())
+ .setRootType(PartitionData.class)
+ .build()) {
+ for (PartitionData record : reader) {
+ readRecords.add(record);
+ }
+ }
+
+ assertThat(readRecords).hasSize(testData.size());
+
+ for (int i = 0; i < testData.size(); i++) {
+ Record expected = testData.get(i);
+ PartitionData actual = readRecords.get(i);
+
+ assertThat(actual.get(0, Long.class)).isEqualTo(expected.get(0,
Long.class));
+ assertThat(actual.get(1, String.class)).isEqualTo(expected.get(1,
String.class));
+ }
+ }
+
+ @TestTemplate
+ public void testCustomTypeForNestedField() throws IOException {
+ FileFormat fileFormat = FileFormat.fromString(format);
+ OutputFile outputFile = fileIO.newOutputFile(tempDir.resolve("test." +
format).toString());
+
+ List<Record> testData = createNestedTestRecords();
+
+ try (FileAppender<Record> appender =
+ InternalData.write(fileFormat,
outputFile).schema(NESTED_SCHEMA).build()) {
+ appender.addAll(testData);
+ }
+
+ InputFile inputFile = fileIO.newInputFile(outputFile.location());
+ List<Record> readRecords = Lists.newArrayList();
+
+ try (CloseableIterable<Record> reader =
+ InternalData.read(fileFormat, inputFile)
+ .project(NESTED_SCHEMA)
+ .setCustomType(2, TestCustomRow.class)
+ .build()) {
+ for (Record record : reader) {
+ readRecords.add(record);
+ }
+ }
+
+ assertThat(readRecords).hasSize(testData.size());
+
+ for (int i = 0; i < testData.size(); i++) {
+ Record expected = testData.get(i);
+ Record actual = readRecords.get(i);
+
+ assertThat(actual.get(0, Long.class)).isEqualTo(expected.get(0,
Long.class));
+
+ Object expectedNested = expected.get(1);
+ Object actualNested = actual.get(1);
+
+ if (expectedNested == null && actualNested == null) {
+ continue;
+ }
+
+ if (actualNested != null) {
+ assertThat(actualNested)
+ .as("Custom type should be TestCustomRow, but was: " +
actualNested.getClass())
+ .isInstanceOf(TestCustomRow.class);
+ TestCustomRow customRow = (TestCustomRow) actualNested;
+ Record expectedRecord = (Record) expectedNested;
+
+ assertThat(customRow.get(0, Long.class))
+ .isEqualTo(expectedRecord.get(0, Long.class)); // inner_id
+ assertThat(customRow.get(1, String.class))
+ .isEqualTo(expectedRecord.get(1, String.class)); // inner_name
+ }
+ }
+ }
+
+ private List<Record> createSimpleTestRecords() {
+ Schema schema = simpleSchema();
+ List<Record> records = Lists.newArrayList();
+
+ Record record1 = GenericRecord.create(schema);
+ record1.set(0, 1L);
+ record1.set(1, "Alice");
+
+ Record record2 = GenericRecord.create(schema);
+ record2.set(0, 2L);
+ record2.set(1, "Bob");
+
+ records.add(record1);
+ records.add(record2);
+
+ return records;
+ }
+
+ private List<Record> createNestedTestRecords() {
+ List<Record> records = Lists.newArrayList();
+
+ Record record1 = GenericRecord.create(NESTED_SCHEMA);
+ record1.set(0, 1L);
+
+ Record nestedStruct1 =
+
GenericRecord.create(NESTED_SCHEMA.findType("nested_struct").asStructType());
+ nestedStruct1.set(0, 100L);
+ nestedStruct1.set(1, "inner_alice");
+ record1.set(1, nestedStruct1);
+
+ Record record2 = GenericRecord.create(NESTED_SCHEMA);
+ record2.set(0, 2L);
+ record2.set(1, null); // null nested struct
+
+ records.add(record1);
+ records.add(record2);
+
+ return records;
+ }
+
+ private Schema simpleSchema() {
+ return new Schema(
+ Types.NestedField.required(1, "id", Types.LongType.get()),
+ Types.NestedField.optional(2, "name", Types.StringType.get()));
+ }
+
+ public static class TestCustomRow implements StructLike {
Review Comment:
can we enhance the `CustomRow` from `TestHelpers` class by adding a new
public constructor that takes a struct type?
##########
parquet/src/main/java/org/apache/iceberg/data/parquet/BaseParquetReaders.java:
##########
@@ -75,6 +78,16 @@ protected ParquetValueReader<T> createReader(
}
}
+ /**
+ * This method can be overridden to provide a custom implementation which
also uses the fieldId of
+ * the Schema when creating the struct reader
+ */
+ protected ParquetValueReader<T> createStructReader(
Review Comment:
A little weird that revapi complains about API change for non-public class.
Should we just modify the original method in line 91 directly? there are
only two child classes `InternalReader` and `GenericParquetReaders`. Then we
can avoid the fallback behavior, which is a bit odd to me.
##########
core/src/test/java/org/apache/iceberg/TestInternalData.java:
##########
@@ -0,0 +1,245 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.IOException;
+import java.nio.file.Path;
+import java.util.Arrays;
+import java.util.List;
+import org.apache.iceberg.data.GenericRecord;
+import org.apache.iceberg.data.Record;
+import org.apache.iceberg.io.CloseableIterable;
+import org.apache.iceberg.io.FileAppender;
+import org.apache.iceberg.io.FileIO;
+import org.apache.iceberg.io.InputFile;
+import org.apache.iceberg.io.OutputFile;
+import org.apache.iceberg.relocated.com.google.common.collect.Lists;
+import org.apache.iceberg.types.Types;
+import org.junit.jupiter.api.TestTemplate;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.io.TempDir;
+
+@ExtendWith(ParameterizedTestExtension.class)
+public class TestInternalData {
+
+ @Parameter(index = 0)
+ private String format;
+
+ @Parameters(name = "format={0}")
+ public static Object[][] parameters() {
+ return new Object[][] {{"avro"}, {"parquet"}};
+ }
+
+ private static final Schema NESTED_SCHEMA =
+ new Schema(
+ Types.NestedField.required(1, "outer_id", Types.LongType.get()),
+ Types.NestedField.optional(
+ 2,
+ "nested_struct",
+ Types.StructType.of(
+ Types.NestedField.optional(3, "inner_id",
Types.LongType.get()),
+ Types.NestedField.optional(4, "inner_name",
Types.StringType.get()))));
+
+ @TempDir private Path tempDir;
+
+ private final FileIO fileIO = new TestTables.LocalFileIO();
+
+ @TestTemplate
+ public void testCustomRootType() throws IOException {
+ FileFormat fileFormat = FileFormat.fromString(format);
+ OutputFile outputFile = fileIO.newOutputFile(tempDir.resolve("test." +
format).toString());
+
+ List<Record> testData = createSimpleTestRecords();
+
+ try (FileAppender<Record> appender =
+ InternalData.write(fileFormat,
outputFile).schema(simpleSchema()).build()) {
+ appender.addAll(testData);
+ }
+
+ InputFile inputFile = fileIO.newInputFile(outputFile.location());
+ List<PartitionData> readRecords = Lists.newArrayList();
+
+ try (CloseableIterable<PartitionData> reader =
+ InternalData.read(fileFormat, inputFile)
+ .project(simpleSchema())
+ .setRootType(PartitionData.class)
+ .build()) {
+ for (PartitionData record : reader) {
+ readRecords.add(record);
+ }
+ }
+
+ assertThat(readRecords).hasSize(testData.size());
+
+ for (int i = 0; i < testData.size(); i++) {
+ Record expected = testData.get(i);
+ PartitionData actual = readRecords.get(i);
+
+ assertThat(actual.get(0, Long.class)).isEqualTo(expected.get(0,
Long.class));
+ assertThat(actual.get(1, String.class)).isEqualTo(expected.get(1,
String.class));
+ }
+ }
+
+ @TestTemplate
+ public void testCustomTypeForNestedField() throws IOException {
+ FileFormat fileFormat = FileFormat.fromString(format);
+ OutputFile outputFile = fileIO.newOutputFile(tempDir.resolve("test." +
format).toString());
+
+ List<Record> testData = createNestedTestRecords();
+
+ try (FileAppender<Record> appender =
+ InternalData.write(fileFormat,
outputFile).schema(NESTED_SCHEMA).build()) {
+ appender.addAll(testData);
+ }
+
+ InputFile inputFile = fileIO.newInputFile(outputFile.location());
+ List<Record> readRecords = Lists.newArrayList();
+
+ try (CloseableIterable<Record> reader =
+ InternalData.read(fileFormat, inputFile)
+ .project(NESTED_SCHEMA)
+ .setCustomType(2, TestCustomRow.class)
+ .build()) {
+ for (Record record : reader) {
+ readRecords.add(record);
+ }
+ }
+
+ assertThat(readRecords).hasSize(testData.size());
+
+ for (int i = 0; i < testData.size(); i++) {
+ Record expected = testData.get(i);
+ Record actual = readRecords.get(i);
+
+ assertThat(actual.get(0, Long.class)).isEqualTo(expected.get(0,
Long.class));
+
+ Object expectedNested = expected.get(1);
+ Object actualNested = actual.get(1);
+
+ if (expectedNested == null && actualNested == null) {
+ continue;
+ }
+
+ if (actualNested != null) {
+ assertThat(actualNested)
+ .as("Custom type should be TestCustomRow, but was: " +
actualNested.getClass())
+ .isInstanceOf(TestCustomRow.class);
+ TestCustomRow customRow = (TestCustomRow) actualNested;
+ Record expectedRecord = (Record) expectedNested;
+
+ assertThat(customRow.get(0, Long.class))
+ .isEqualTo(expectedRecord.get(0, Long.class)); // inner_id
+ assertThat(customRow.get(1, String.class))
+ .isEqualTo(expectedRecord.get(1, String.class)); // inner_name
+ }
+ }
+ }
+
+ private List<Record> createSimpleTestRecords() {
Review Comment:
instead of the two create methods, maybe use
`RandomInternalData.generate(Schema schema, int numRecords, long seed)` ?
##########
core/src/test/java/org/apache/iceberg/TestInternalData.java:
##########
@@ -0,0 +1,245 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.IOException;
+import java.nio.file.Path;
+import java.util.Arrays;
+import java.util.List;
+import org.apache.iceberg.data.GenericRecord;
+import org.apache.iceberg.data.Record;
+import org.apache.iceberg.io.CloseableIterable;
+import org.apache.iceberg.io.FileAppender;
+import org.apache.iceberg.io.FileIO;
+import org.apache.iceberg.io.InputFile;
+import org.apache.iceberg.io.OutputFile;
+import org.apache.iceberg.relocated.com.google.common.collect.Lists;
+import org.apache.iceberg.types.Types;
+import org.junit.jupiter.api.TestTemplate;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.io.TempDir;
+
+@ExtendWith(ParameterizedTestExtension.class)
+public class TestInternalData {
+
+ @Parameter(index = 0)
+ private String format;
+
+ @Parameters(name = "format={0}")
+ public static Object[][] parameters() {
+ return new Object[][] {{"avro"}, {"parquet"}};
Review Comment:
nit: we can use enum directly here.
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueReaders.java:
##########
@@ -189,6 +191,16 @@ public static ParquetValueReader<Long>
int96Timestamps(ColumnDescriptor desc) {
return new TimestampInt96Reader(desc);
}
+ @SuppressWarnings("unchecked")
+ public static <T extends StructLike> ParquetValueReader<T> structLikeReader(
+ List<ParquetValueReader<?>> readers, Types.StructType struct, Class<T>
structClass) {
+ if (structClass.equals(Record.class)) {
Review Comment:
`Record` extends from `StructLike` type. can we remove the `RecordReader`?
Maybe the only reason for potentially small performance difference with
`GenericRecord.copy()` in the `newStructData` method.
```
// GenericRecord.copy() is more performant than
GenericRecord.create(StructType) since
// NAME_MAP_CACHE access is eliminated. Using copy here to gain
performance.
```
##########
core/src/test/java/org/apache/iceberg/TestInternalData.java:
##########
@@ -0,0 +1,245 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg;
+
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.IOException;
+import java.nio.file.Path;
+import java.util.Arrays;
+import java.util.List;
+import org.apache.iceberg.data.GenericRecord;
+import org.apache.iceberg.data.Record;
+import org.apache.iceberg.io.CloseableIterable;
+import org.apache.iceberg.io.FileAppender;
+import org.apache.iceberg.io.FileIO;
+import org.apache.iceberg.io.InputFile;
+import org.apache.iceberg.io.OutputFile;
+import org.apache.iceberg.relocated.com.google.common.collect.Lists;
+import org.apache.iceberg.types.Types;
+import org.junit.jupiter.api.TestTemplate;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.junit.jupiter.api.io.TempDir;
+
+@ExtendWith(ParameterizedTestExtension.class)
+public class TestInternalData {
+
+ @Parameter(index = 0)
+ private String format;
+
+ @Parameters(name = "format={0}")
+ public static Object[][] parameters() {
+ return new Object[][] {{"avro"}, {"parquet"}};
+ }
+
+ private static final Schema NESTED_SCHEMA =
+ new Schema(
+ Types.NestedField.required(1, "outer_id", Types.LongType.get()),
+ Types.NestedField.optional(
+ 2,
+ "nested_struct",
+ Types.StructType.of(
+ Types.NestedField.optional(3, "inner_id",
Types.LongType.get()),
+ Types.NestedField.optional(4, "inner_name",
Types.StringType.get()))));
+
+ @TempDir private Path tempDir;
+
+ private final FileIO fileIO = new TestTables.LocalFileIO();
+
+ @TestTemplate
+ public void testCustomRootType() throws IOException {
+ FileFormat fileFormat = FileFormat.fromString(format);
+ OutputFile outputFile = fileIO.newOutputFile(tempDir.resolve("test." +
format).toString());
+
+ List<Record> testData = createSimpleTestRecords();
+
+ try (FileAppender<Record> appender =
+ InternalData.write(fileFormat,
outputFile).schema(simpleSchema()).build()) {
+ appender.addAll(testData);
+ }
+
+ InputFile inputFile = fileIO.newInputFile(outputFile.location());
+ List<PartitionData> readRecords = Lists.newArrayList();
+
+ try (CloseableIterable<PartitionData> reader =
+ InternalData.read(fileFormat, inputFile)
+ .project(simpleSchema())
+ .setRootType(PartitionData.class)
+ .build()) {
+ for (PartitionData record : reader) {
+ readRecords.add(record);
+ }
+ }
+
+ assertThat(readRecords).hasSize(testData.size());
+
+ for (int i = 0; i < testData.size(); i++) {
+ Record expected = testData.get(i);
+ PartitionData actual = readRecords.get(i);
+
+ assertThat(actual.get(0, Long.class)).isEqualTo(expected.get(0,
Long.class));
+ assertThat(actual.get(1, String.class)).isEqualTo(expected.get(1,
String.class));
+ }
+ }
+
+ @TestTemplate
+ public void testCustomTypeForNestedField() throws IOException {
+ FileFormat fileFormat = FileFormat.fromString(format);
+ OutputFile outputFile = fileIO.newOutputFile(tempDir.resolve("test." +
format).toString());
+
+ List<Record> testData = createNestedTestRecords();
+
+ try (FileAppender<Record> appender =
+ InternalData.write(fileFormat,
outputFile).schema(NESTED_SCHEMA).build()) {
+ appender.addAll(testData);
+ }
+
+ InputFile inputFile = fileIO.newInputFile(outputFile.location());
+ List<Record> readRecords = Lists.newArrayList();
+
+ try (CloseableIterable<Record> reader =
+ InternalData.read(fileFormat, inputFile)
+ .project(NESTED_SCHEMA)
+ .setCustomType(2, TestCustomRow.class)
+ .build()) {
+ for (Record record : reader) {
+ readRecords.add(record);
+ }
+ }
+
+ assertThat(readRecords).hasSize(testData.size());
+
+ for (int i = 0; i < testData.size(); i++) {
+ Record expected = testData.get(i);
+ Record actual = readRecords.get(i);
+
+ assertThat(actual.get(0, Long.class)).isEqualTo(expected.get(0,
Long.class));
+
+ Object expectedNested = expected.get(1);
+ Object actualNested = actual.get(1);
+
+ if (expectedNested == null && actualNested == null) {
+ continue;
+ }
+
+ if (actualNested != null) {
+ assertThat(actualNested)
+ .as("Custom type should be TestCustomRow, but was: " +
actualNested.getClass())
+ .isInstanceOf(TestCustomRow.class);
+ TestCustomRow customRow = (TestCustomRow) actualNested;
+ Record expectedRecord = (Record) expectedNested;
+
+ assertThat(customRow.get(0, Long.class))
+ .isEqualTo(expectedRecord.get(0, Long.class)); // inner_id
+ assertThat(customRow.get(1, String.class))
+ .isEqualTo(expectedRecord.get(1, String.class)); // inner_name
+ }
+ }
+ }
+
+ private List<Record> createSimpleTestRecords() {
+ Schema schema = simpleSchema();
+ List<Record> records = Lists.newArrayList();
+
+ Record record1 = GenericRecord.create(schema);
+ record1.set(0, 1L);
+ record1.set(1, "Alice");
+
+ Record record2 = GenericRecord.create(schema);
+ record2.set(0, 2L);
+ record2.set(1, "Bob");
+
+ records.add(record1);
+ records.add(record2);
+
+ return records;
+ }
+
+ private List<Record> createNestedTestRecords() {
+ List<Record> records = Lists.newArrayList();
+
+ Record record1 = GenericRecord.create(NESTED_SCHEMA);
+ record1.set(0, 1L);
+
+ Record nestedStruct1 =
+
GenericRecord.create(NESTED_SCHEMA.findType("nested_struct").asStructType());
+ nestedStruct1.set(0, 100L);
+ nestedStruct1.set(1, "inner_alice");
+ record1.set(1, nestedStruct1);
+
+ Record record2 = GenericRecord.create(NESTED_SCHEMA);
+ record2.set(0, 2L);
+ record2.set(1, null); // null nested struct
+
+ records.add(record1);
+ records.add(record2);
+
+ return records;
+ }
+
+ private Schema simpleSchema() {
Review Comment:
nit: define it at the beginning of this class like the nested schema?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
