Copilot commented on code in PR #211:
URL: https://github.com/apache/iceberg-cpp/pull/211#discussion_r2321866686
##########
src/iceberg/transform.h:
##########
@@ -56,8 +56,40 @@ enum class TransformType {
kVoid,
};
+constexpr std::string_view kUnknownName = "unknown";
+constexpr std::string_view kIdentityName = "identity";
+constexpr std::string_view kBucketName = "bucket";
+constexpr std::string_view kTruncateName = "truncate";
+constexpr std::string_view kYearName = "year";
+constexpr std::string_view kMonthName = "month";
+constexpr std::string_view kDayName = "day";
+constexpr std::string_view kHourName = "hour";
+constexpr std::string_view kVoidName = "void";
Review Comment:
The string constants are now exposed globally in the header file, which may
lead to symbol pollution. Consider placing them in an anonymous namespace or
using internal linkage to prevent unintended external usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
