wgtmac commented on code in PR #211:
URL: https://github.com/apache/iceberg-cpp/pull/211#discussion_r2328728156
##########
cmake_modules/IcebergBuildUtils.cmake:
##########
@@ -131,7 +131,7 @@ function(add_iceberg_lib LIB_NAME)
endif()
if(LIB_INCLUDES)
- target_include_directories(${LIB_NAME}_shared SYSTEM PUBLIC
${ARG_EXTRA_INCLUDES})
Review Comment:
@raulcd I think I just copied the same thing from Apache Arrow. Do you have
any idea why it was added there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
