HuaHuaY commented on code in PR #211:
URL: https://github.com/apache/iceberg-cpp/pull/211#discussion_r2322426099
##########
src/iceberg/table_metadata.h:
##########
@@ -87,11 +87,11 @@ struct ICEBERG_EXPORT TableMetadata {
/// The highest assigned column ID for the table
int32_t last_column_id;
/// A list of schemas
- std::vector<std::shared_ptr<Schema>> schemas;
Review Comment:
```sh
In file included from
/home/runner/work/iceberg-cpp/iceberg-cpp/src/iceberg/catalog/in_memory_catalog.cc:27:
/home/runner/work/iceberg-cpp/iceberg-cpp/src/iceberg/table_metadata.h:125:35:
error: declaration of ‘iceberg::Result<std::shared_ptr<iceberg::Schema> >
iceberg::TableMetadata::Schema() const’ changes meaning of ‘Schema’
[-Wchanges-meaning]
125 | Result<std::shared_ptr<Schema>> Schema() const;
| ^~~~~~
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
