HuaHuaY commented on code in PR #211:
URL: https://github.com/apache/iceberg-cpp/pull/211#discussion_r2322396837
##########
src/iceberg/transform.h:
##########
@@ -56,8 +57,40 @@ enum class TransformType {
kVoid,
};
+constexpr std::string_view kUnknownName = "unknown";
Review Comment:
The constexpr function below needs these constants. Constexpr function is
implicitly inline so we have to move the definition to header file to avoid
warning. Or we can remove constexpr. Either solution is fine for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
