nullccxsy commented on code in PR #180:
URL: https://github.com/apache/iceberg-cpp/pull/180#discussion_r2312967000
##########
src/iceberg/schema.h:
##########
@@ -29,8 +29,10 @@
#include <vector>
#include "iceberg/iceberg_export.h"
+#include "iceberg/result.h"
#include "iceberg/schema_field.h"
#include "iceberg/type.h"
+#include "iceberg/util/string_util.h"
Review Comment:
StringHash is need in
```
/// Mapping from lowercased field name to field id
mutable std::unordered_map<std::string, int32_t, StringHash,
std::equal_to<>>
lowercase_name_to_id_;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
