nullccxsy commented on code in PR #180:
URL: https://github.com/apache/iceberg-cpp/pull/180#discussion_r2303346670
##########
src/iceberg/schema.h:
##########
@@ -29,11 +29,23 @@
#include <vector>
#include "iceberg/iceberg_export.h"
+#include "iceberg/result.h"
#include "iceberg/schema_field.h"
#include "iceberg/type.h"
namespace iceberg {
+/// \brief Transparent hash function that supports std::string_view as lookup
key
+///
+/// Enables std::unordered_map to directly accept std::string_view lookup keys
+/// without creating temporary std::string objects, using C++20's transparent
lookup.
+struct string_hash {
Review Comment:
The logic for detecting duplicate IDs has been moved to GetFieldById. Didn’t
we agree earlier that no exceptions would be thrown?
##########
src/iceberg/schema.h:
##########
@@ -29,11 +29,23 @@
#include <vector>
#include "iceberg/iceberg_export.h"
+#include "iceberg/result.h"
#include "iceberg/schema_field.h"
#include "iceberg/type.h"
namespace iceberg {
+/// \brief Transparent hash function that supports std::string_view as lookup
key
+///
+/// Enables std::unordered_map to directly accept std::string_view lookup keys
+/// without creating temporary std::string objects, using C++20's transparent
lookup.
+struct string_hash {
Review Comment:
The logic for detecting duplicate IDs has been moved to GetFieldById. Didn’t
we agree earlier that no exceptions would be thrown?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
