danielcweeks commented on code in PR #13899:
URL: https://github.com/apache/iceberg/pull/13899#discussion_r2294236656
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3InputStream.java:
##########
@@ -165,7 +165,9 @@ public void readFully(long position, byte[] buffer, int
offset, int length) thro
String range = String.format("bytes=%s-%s", position, position + length -
1);
- IOUtil.readFully(readRange(range), buffer, offset, length);
+ try (InputStream stream = readRange(range)) {
Review Comment:
Nice find @nandorKollar (bad assumption that `readFully` would close the
stream). I would agree there's the same issue for `readTail` and the other
implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
