AnatolyPopov commented on code in PR #13899:
URL: https://github.com/apache/iceberg/pull/13899#discussion_r2293608473
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3InputStream.java:
##########
@@ -165,7 +165,9 @@ public void readFully(long position, byte[] buffer, int
offset, int length) thro
String range = String.format("bytes=%s-%s", position, position + length -
1);
- IOUtil.readFully(readRange(range), buffer, offset, length);
+ try (InputStream stream = readRange(range)) {
Review Comment:
Yes. I was starting small to see if that's the correct approach. I will do
the follow up PRs for other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
